Upgrade to eslint v9 and update all dependencies #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanmaric
force-pushed
the
eslint-v9
branch
2 times, most recently
from
4ee037b to
3cd313a
Compare
kadza
approved these changes
Jan 23, 2025
| @@ -2,6 +2,67 @@ | |||
|
|
|||
| ## Unreleased | |||
There was a problem hiding this comment.
I don't follow. What's your concern?
| @@ -30,9 +37,11 @@ module.exports = { | |||
| '@typescript-eslint/prefer-readonly': 'error', | |||
| '@typescript-eslint/prefer-reduce-type-parameter': 'error', | |||
| '@typescript-eslint/prefer-string-starts-ends-with': 'error', | |||
| '@typescript-eslint/sort-type-constituents': 'error', | |||
There was a problem hiding this comment.
@kadza was intended as the rule has been deprecated: https://typescript-eslint.io/rules/sort-type-constituents/
But I actually forgot to add it back via the Perfectionist package. Good catch.
| 'prefer-arrow-callback': 'error', | ||
| 'prefer-destructuring': 'error', |
There was a problem hiding this comment.
This one I intentionally disabled because in practice it produces more harm than good.
One clear example is that it forces you to change:
let thing
if (otherThing.length) {
thing = otherThing[0]
}To this:
let thing
if (otherThing.length) {
;[thing] = otherThing
}Which is absurd.
The other thing is that destructing, even tho implemented in all engines almost a decade ago and optimized the hell of it, is still slower than direct property access. It will usually be negligible for most of the kind of stuff we write at Masterworks, but still one less reason to force it.
**Flat Config** This major release requires a complete rewrite of your projects' ESLint config file as we moved to the new Flat Config format. Start by reading ESLint's migration guide: https://eslint.org/docs/latest/use/configure/migration-guide **ESM-only** This release moves forward and assumes ESM-only projects, so if you're still using CommonJS, you'll need to update your project to use ESM first. **Peer-dependencies** Some peer dependencies have been changed: - `@typescript-eslint/eslint-plugin` -> `typescript-eslint` - `eslint-plugin-import` -> `eslint-plugin-import-x` - `eslint-plugin-node` -> `eslint-plugin-n` - `@typescript-eslint/parser` is now packaged into `typescript-eslint` - The resolver has changed to `eslint-import-resolver-typescript` Packages to remove: ``` eslint-plugin-import eslint-plugin-node @typescript-eslint/eslint-plugin @typescript-eslint/parser ``` Packages to add: ``` @eslint/js eslint-plugin-import-x eslint-plugin-n typescript-eslint eslint-import-resolver-typescript ``` Packages to update: ``` eslint eslint-plugin-jsx-a11y eslint-plugin-react-hooks eslint-plugin-react ``` **Prettier** The `prettier` entry has been changed from .cjs to .js, as we are now using ESM-only. ```diff - "prettier": "@masterworks/eslint-config-masterworks/prettier", + "prettier": "@masterworks/eslint-config-masterworks/prettier/prettier.js", ``` **TypeScript** The minimum compatible TypeScript version is now 5.7.3. ***React PropTypes*** Rules related to PropTypes have been removed, as they have been deprecated and removed by the React Core Team. You should ideally remove PropTypes from your project and use TypeScript instead. **Improved detection of deprecated APIs** Most presets have warnings for the usage of deprecated rules. With the different upgrades this detection has improved and you most probably will get new warnings. [f:8h]
stefanmaric
force-pushed
the
eslint-v9
branch
from
3cd313a to
5a3bd17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flat Config
This major release requires a complete rewrite of your projects' ESLint config file as we moved to the new Flat Config format.
Start by reading ESLint's migration guide: https://eslint.org/docs/latest/use/configure/migration-guide
ESM-only
This release moves forward and assumes ESM-only projects, so if you're still using CommonJS, you'll need to update your project to use ESM first.
Peer-dependencies
Some peer dependencies have been changed:
@typescript-eslint/eslint-plugin->typescript-eslinteslint-plugin-import->eslint-plugin-import-xeslint-plugin-node->eslint-plugin-n@typescript-eslint/parseris now packaged intotypescript-eslinteslint-import-resolver-typescriptPackages to remove:
Packages to add:
Packages to update:
Prettier
The
prettierentry has been changed from .cjs to .js, as we are now using ESM-only.TypeScript
The minimum compatible TypeScript version is now 5.7.3.
React PropTypes
Rules related to PropTypes have been removed, as they have been deprecated and removed by the React Core Team. You should ideally remove PropTypes from your project and use TypeScript instead.
Improved detection of deprecated APIs
Most presets have warnings for the usage of deprecated rules. With the different upgrades this detection has improved and you most probably will get new warnings.