Fix console port forward step #30823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kay-kim it looks like a lot's duplicated between the mini-kube and kubectl setup. Should we create partials for at least some of the common steps? Or would you prefer the duplication for maximal flexibility? |
We extend the existing port forward to retry on failure.
SangJunBak
force-pushed
the
jun/self-managed-console-kind-fixes
branch
from
066d2a9 to
af3f402
Compare
|
Oh, will definitely create shortcodes/partials. Heh heh ... I just copied+paste for speed right before going on Thanksgiving break 😄 I'll update those next week. Didn't have time to do the updates this week - but, next week is mostly self-managed docs work (including AWS instructions). |
kay-kim
reviewed
Dec 14, 2024
| interrupted long-running requests through a standard port-forward cause the port forward to hang. The command above | ||
| automatically restarts the port forwarding if an error occurs, ensuring a more stable | ||
| connection. It detects failures by monitoring for "portforward.go" error messages. | ||
| {{< /note >}} |
There was a problem hiding this comment.
Heh ... yeah ... our note shortcode needs tweak. I see you did left-aligning below and not here. I'll add a patch to just fix the note, so that people can do the sensible thing like you did here.
kay-kim
approved these changes
Dec 14, 2024
alex-hunt-materialize
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We extend the existing port forward to retry on failure.
Motivation
Fixes https://github.com/MaterializeInc/console/issues/3582
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.