Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Fix webhook.py platform-check #30847

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

ParkMyCar
Copy link
Member

This PR fixes the webhook.py platform-check.

In #30821 I failed to consider the scenario of when a platform check runs on a version < v0.128.0 and we create the webhook source with the CREATE SOURCE ... FROM WEBHOOK, and then later check with a version >= v0.128.0, like our Nightly tests do.

This PR changes the check to only use the new CREATE TABLE ... FROM WEBHOOK syntax if we're on a version >= v0.128.0

Motivation

Fix Nightly

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@ParkMyCar ParkMyCar requested a review from a team as a code owner December 16, 2024 21:59
@ParkMyCar ParkMyCar requested a review from bkirwi December 16, 2024 21:59
@ParkMyCar ParkMyCar force-pushed the tests/fix-webhook-check branch from 3c70508 to 90b7e11 Compare December 16, 2024 22:05
@ParkMyCar ParkMyCar force-pushed the tests/fix-webhook-check branch from 90b7e11 to 300487b Compare December 16, 2024 22:07
@bkirwi
Copy link
Contributor

bkirwi commented Dec 16, 2024

Kicked off the relevant nightlies... looks like they're still failing.

@ParkMyCar
Copy link
Member Author

Kicked off the relevant nightlies... looks like they're still failing.

Yeah 🤦 really taking a moment to think through it, I'm pretty sure what I initially tried to do with this check just isn't possible. After the second iteration the tests were still failing because when the initialize step is run in a version <0.128.0 which means the table just wouldn't be created.

Updated this to move the CREATE TABLE ... FROM WEBHOOK to its own check entirely with a _can_run(...). Third time is the charm!

@ParkMyCar ParkMyCar force-pushed the tests/fix-webhook-check branch from c07f5e4 to b54334d Compare December 17, 2024 03:30
@ParkMyCar ParkMyCar requested a review from jkosh44 December 17, 2024 14:19
@ParkMyCar ParkMyCar merged commit 72c87db into MaterializeInc:main Dec 17, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants