tests: Fix webhook.py
platform-check
#30847
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
webhook.py
platform-check.In #30821 I failed to consider the scenario of when a platform check runs on a version < v0.128.0 and we create the webhook source with the
CREATE SOURCE ... FROM WEBHOOK
, and then later check with a version >= v0.128.0, like our Nightly tests do.This PR changes the check to only use the new
CREATE TABLE ... FROM WEBHOOK
syntax if we're on a version >=v0.128.0
Motivation
Fix Nightly
Checklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way), then it is tagged with aT-proto
label.