Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

catalog: Update deploy generation comments #31213

Merged
merged 3 commits into from
Jan 28, 2025
Merged

catalog: Update deploy generation comments #31213

merged 3 commits into from
Jan 28, 2025

Conversation

jkosh44
Copy link
Contributor

@jkosh44 jkosh44 commented Jan 27, 2025

Follow up to 5df1932 to update comments to reference build version instead of deploy generation.

Motivation

This PR refactors existing code.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@jkosh44
catalog: Update deploy generation comments
078ba82 
Follow up to 5df1932 to update
comments to reference build version instead of deploy generation.
@jkosh44 jkosh44 requested a review from a team as a code owner January 27, 2025 22:26
@jkosh44 jkosh44 requested a review from aljoscha January 27, 2025 22:26
@jkosh44 jkosh44 enabled auto-merge (squash) January 27, 2025 22:27
@jkosh44
Merge branch 'main' of github.com:MaterializeInc/materialize into upd…
244a6b2 
…ate-generation-comments

# Conflicts:
#	src/catalog/src/expr_cache.rs
@jkosh44 jkosh44 requested a review from ParkMyCar January 28, 2025 16:56
@jkosh44 jkosh44 merged commit 8d58aa0 into MaterializeInc:main Jan 28, 2025
79 checks passed
@jkosh44 jkosh44 deleted the update-generation-comments branch January 28, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ParkMyCar ParkMyCar ParkMyCar approved these changes

@aljoscha aljoscha Awaiting requested review from aljoscha aljoscha is a code owner automatically assigned from MaterializeInc/adapter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkosh44 @ParkMyCar