Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCP terraform + helm-chart test #31214

Merged
merged 1 commit into from
Jan 29, 2025
Merged

GCP terraform + helm-chart test #31214

merged 1 commit into from
Jan 29, 2025
+591 −67

Conversation

def-
Copy link
Contributor

@def- def- commented Jan 28, 2025 •
edited
Loading

Run for proof: https://buildkite.com/materialize/nightly/builds/10988#0194ae05-1bbd-42c2-a12a-5bf7939cad72

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@def- def- requested a review from a team as a code owner January 28, 2025 06:09
@def- def- force-pushed the pr-gcp-terraform branch 16 times, most recently from 5da8c25 to 659fff1 Compare January 28, 2025 18:02
bobbyiliev
bobbyiliev approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@bobbyiliev bobbyiliev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for handling all that @def-!

test/terraform/gcp/main.tf Outdated Show resolved Hide resolved
test/terraform/gcp/main.tf Outdated Show resolved Hide resolved
test/terraform/mzcompose.py Outdated Show resolved Hide resolved
@def- def- force-pushed the pr-gcp-terraform branch 2 times, most recently from 1e7bb70 to 4f61ee8 Compare January 28, 2025 18:23
@def- def- force-pushed the pr-gcp-terraform branch from 4f61ee8 to fcc0efd Compare January 29, 2025 07:48
@def- def- merged commit 19a17fd into MaterializeInc:main Jan 29, 2025
84 checks passed
@def- def- deleted the pr-gcp-terraform branch January 29, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbyiliev bobbyiliev bobbyiliev approved these changes

@doy-materialize doy-materialize Awaiting requested review from doy-materialize

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@def- @bobbyiliev