Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mz emulator: Disable statement logging by default #31292

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

def-
Copy link
Contributor

@def- def- commented Feb 5, 2025

Suggested by Moritz in https://materializeinc.slack.com/archives/C07FX1W1Y03/p1738762660566029

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@def- def- requested a review from antiguru February 5, 2025 15:05
Copy link
Member

@antiguru antiguru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was looking for this line and didn't spot it! Thank you, this looks good.

@def- def- merged commit 40231e1 into MaterializeInc:main Feb 5, 2025
68 checks passed
@def- def- deleted the pr-statement-logging-docker-image branch February 5, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants