Add urlencode for the db password #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kay-kim
approved these changes
Feb 25, 2025
There was a problem hiding this comment.
Thank you!!!!! Since we've set the special to false, we probably don't need to urlencode but I generally find it good to have for future-proofing (since, sometime in the future, people might allow special characters or override special in the random_password ... and will have forgotten the urlencode).
Ah ... I see that we keep the variable in root ... we just use the random_password for the simple example. Perfect!
kay-kim
reviewed
Feb 26, 2025
| @@ -153,7 +153,7 @@ locals { | |||
| metadata_backend_url = format( | |||
| "postgres://%s:%s@%s/%s?sslmode=require", | |||
| var.database_username, | |||
| var.database_password, | |||
| urlencode(var.database_password), | |||
There was a problem hiding this comment.
QQ: In the outputs.tf ... we print out the non-urlencoded metadata_backend_url. Does it matter? I'm guessing not since we don't even need to output that anymore, yes?
bobbyiliev
force-pushed
the
urlencode-db-string
branch
from
9af3342 to
87ee381
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.