Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preventing reset issues #102

Closed
computron opened this issue Mar 29, 2024 · 1 comment · Fixed by #189
Closed

preventing reset issues #102

computron opened this issue Mar 29, 2024 · 1 comment · Fixed by #189

Comments

@computron
Copy link
Collaborator

To prevent unintentional resets of production database, I suggest the user needs to type the name of the project (not just "y") in order to reset if the project has more than a handful of Flows in it.

@gpetretto
Copy link
Contributor

At the moment there is an additional safe guard. When running jf admin reset there is also this option:

--max     -m      INTEGER  The database will be reset only if the number of Flows is lower than the specified limit. 0 means no limit [default: 25]

so this means that if there are more than 25 flows in the DB the reset will be refused, even if the confirmation (y) is given. In that case the user will need to pass a suitable -m option (e.g. -m 0) to really reset the DB.

Switching to ask the project name for confirmation could be a good option replacing the -m. Do you think it is worth changing, or was it just to have an additional safe guard against resetting large databases?

@gpetretto gpetretto linked a pull request Sep 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants