Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require date to reset DB #189

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Require date to reset DB #189

merged 1 commit into from
Sep 23, 2024

Conversation

gpetretto
Copy link
Contributor

After some internal discussion, we have decided to address #102 by requiring the addition of today's date from the CLI to reduce the probability of an accidental DB reset.

This also includes an update of the documentation concerning configuration with environment variables. @janosh, can you check if this fits your expectations?

This was linked to issues Sep 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 47.89%. Comparing base (8df1979) to head (01a7f25).

Files with missing lines Patch % Lines
src/jobflow_remote/jobs/jobcontroller.py 33.33% 2 Missing ⚠️
src/jobflow_remote/cli/admin.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #189      +/-   ##
===========================================
- Coverage    47.92%   47.89%   -0.04%     
===========================================
  Files           43       43              
  Lines         5156     5153       -3     
  Branches      1118     1117       -1     
===========================================
- Hits          2471     2468       -3     
- Misses        2424     2425       +1     
+ Partials       261      260       -1     
Files with missing lines Coverage Δ
src/jobflow_remote/cli/admin.py 26.74% <0.00%> (-1.04%) ⬇️
src/jobflow_remote/jobs/jobcontroller.py 35.66% <33.33%> (-0.15%) ⬇️

doc/source/user/projectconf.rst Show resolved Hide resolved
src/jobflow_remote/jobs/jobcontroller.py Show resolved Hide resolved
Copy link
Member

@davidwaroquiers davidwaroquiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to me!

@gpetretto gpetretto merged commit 1b97f4c into develop Sep 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set projects_folder via env var preventing reset issues
4 participants