Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unrecognized props on DOM elements #17

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

aautem
Copy link

@aautem aautem commented Jan 26, 2018

Fixes warnings that React (16.2.0) does not recognize the data-ifEmpty and data-showOnlyWhen props on the buttons in the Toolbar.

@aautem
Copy link
Author

aautem commented Jan 26, 2018

I wasn't able to make a PR to the latest release at v0.3.7 so let me know if there's a better way to handle this.

@MattMcFarland
Copy link
Owner

MattMcFarland commented Jan 26, 2018

Hmm, this is probably my fault for working directly off of master :( I might have to revert my changes back then add this, then break my wip into a branch (should have done this to begin with!)

@aautem
Copy link
Author

aautem commented Jan 29, 2018

Sounds good. Any idea when you might have some time to get to this one? Just curious if I should bypass npm for the time being and add my changes locally or if this will be a quick one to merge in. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants