Upgrade to Angular 16+ #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node 18 is the only version that is still supported by node and Angular 15
Because I could not make @angular-builders/jest work and Angular 15 is EOL in a few days anyway.
|
Looks good! Thanks for adding the types as well, seems like I have been a little lazy using any :D The |
PowerKiKi
commented
May 8, 2024
| @@ -95,7 +96,7 @@ export class CropperPositionService { | |||
| cropperPosition.y1 + settings.cropperScaledMinHeight); | |||
| break; | |||
| case 'center': | |||
| const scale = event.scale; | |||
| const scale = (event as any).scale; | |||
There was a problem hiding this comment.
Not too happy about this change. Maybe you can help me understand where this apparently non-standard property comes from ?
There was a problem hiding this comment.
It comes from the startPinch method which is used by HammerJS for the pinch zoom.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #630, except that I went for Angular 16, because Angular 15 is EOL in a few days, and Angular 16 makes it much easier to work with Jest.