install_production: improve the partition check (nextcloud#1692)

Signed-off-by: szaimen <[email protected]>

Co-authored-by: Daniel Hansson <[email protected]>

nextcloud_install_production.sh

@@ -46,20 +46,10 @@ fi
 is_process_running apt
 is_process_running dpkg
 
-# Test if snapshot already exists
-if does_snapshot_exist "NcVM-installation"
-then
-    msg_box "Unable to continue because a logical volume already exists.
-
-To run this script again, please remove the volume by running:
-'sudo lvremove /dev/ubuntu-vg/NcVM-installation'"
-    exit 1
-fi
-
 # Create a placeholder volume before modifying anything
 if [ -z "$PROVISIONING" ]
 then
-    if yesno_box_no "Do you want to use LVM snapshots to be able to restore your root partition during upgrades and such?
+    if ! does_snapshot_exist "NcVM-installation" && yesno_box_no "Do you want to use LVM snapshots to be able to restore your root partition during upgrades and such?
 Please note: this feature will not be used by this script but by other scripts later on.
 For now we will only create a placeholder volume that will be used to let some space for snapshot volumes."
     then