Take into account global offsets of corners #3 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fab-girard
force-pushed
the
controls
branch
2 times, most recently
from
bf3360b
to
5686d7b
Compare
|
Hello, Fabien |
|
Pull request update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I've asked in #3 issue, it would be better if ControlledBounds takes into account other controls added for instance by other leaflet plugin (I've checked with plugin leaflet-sidebar.
With my modifications, plugin doesn't use anymore size of the map but offsets of corners. Now Leaflet.ControlledBounds is compatible with leaflet-sidebar and I think all controls added by others.
Fabien