flexible names

src/features/projects-management/opfs-projects-listing-service.test.ts

@@ -130,7 +130,7 @@ describe("OPFS project listing service", () => {
     expect(removeMock).toHaveBeenCalled();
   });
 
-  it("throws error if retrieved filenames are corrupted with invalid patterns", async () => {
+  it("ignore retrieved filenames corrupted with invalid patterns", async () => {
     (opfsAdapters.makeOpfsMainDirAdapter as jest.Mock).mockResolvedValueOnce({
       retrieveFilenames: jest
         .fn()
@@ -140,10 +140,10 @@ describe("OPFS project listing service", () => {
         ]),
     });
 
-    await expect(() => retrieveProjectsListing()).rejects.toEqual(
-      new Error(
-        "Invalid project filename (corrupted data?): 91599476-833d-invaliduuid-826b-8fe768fad0bf_My cool API.json"
-      )
-    );
+    const listing = await retrieveProjectsListing();
+
+    expect(listing).toEqual({
+      items: [{ name: "MyAPI", uuid: "82184240-6b29-4ae8-82f5-fbe7d1bb814a" }],
+    });
   });
 });

src/features/projects-management/opfs-projects-listing-service.ts

@@ -27,7 +27,12 @@ export async function retrieveProjectsListing(): Promise<ProjectListing> {
   });
   const filenames = await opfsDir.retrieveFilenames();
   return {
-    items: filenames.map((filename) => getListingItemFromFilename(filename)),
+    items: filenames
+      .reduce(
+        (acc, filename) => [...acc, getListingItemFromFilename(filename)],
+        [] as (ProjectListingItem | null)[]
+      )
+      .filter((it) => it !== null) as ProjectListingItem[],
   };
 }
 

src/services/opfs-projects-shared-internals.ts

@@ -90,12 +90,13 @@ export function getProjectFilename(
  */
 export function getListingItemFromFilename(
   filename: string
-): Pick<Project, "uuid" | "name"> {
+): Pick<Project, "uuid" | "name"> | null {
   const rFilename =
-    /(?<uuid>[a-f0-9]{8}-[a-f0-9]{4}-[a-f0-9]{4}-[a-f0-9]{4}-[a-f0-9]{12})_(?<name>[A-Za-z ]+)\.json/;
+    /^(?<uuid>[a-f0-9]{8}-[a-f0-9]{4}-[a-f0-9]{4}-[a-f0-9]{4}-[a-f0-9]{12})_(?<name>[A-Za-z 0-9]+)\.json$/;
   const match = filename.match(rFilename);
   if (!match || !match.groups) {
-    throw new Error(`Invalid project filename (corrupted data?): ${filename}`);
+    console.error(`Invalid project filename (corrupted data?): ${filename}`);
+    return null;
   }
 
   return {
@@ -110,13 +111,23 @@ export function getListingItemFromFilename(
 export const PROJECTS_OPFS_SUBDIRECTORY = "projects";
 
 function hygienizeProjectName(name: string): string {
-  return name.trim().replaceAll(".json", "").replaceAll('"', "");
+  return (
+    name
+      // just avoiding confusing/ugly trailing spaces:
+      .trim()
+      // possibly offends our regex of listing retrieval:
+      .replaceAll(/.json$/i, "")
+      // possibly offends our regex of listing retrieval:
+      .replaceAll('"', "")
+      // throws error on OPFS:
+      .replaceAll("/", " ")
+  );
 }
 
 async function retrieveProjectFilenameByUuid(uuid: string): Promise<string> {
   const allFilenames = await retrieveProjectsFilenames();
   const filename = allFilenames.find(
-    (filename) => getListingItemFromFilename(filename).uuid === uuid
+    (filename) => getListingItemFromFilename(filename)?.uuid === uuid
   );
 
   if (!filename) {