Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option for max Environmental Controller radius #1906

Open
wants to merge 3 commits into
base: 1.12
Choose a base branch
from

Conversation

ajthemacboy
Copy link

This is completely untested. I don't know Java but I think this might work. I didn't add this option to the default config file yet because I haven't found where to do that... maybe it is done automatically?

Would fix #1903.

@ajthemacboy
Copy link
Author

@josephcsible This automatically added an option in the config, but the config isn't changing the maximum value of the slider in the Environmental Controller. The max value there is still 100. I've looked but I can't find any place to change the max slider value... do you know where I could?

@josephcsible
Copy link
Collaborator

josephcsible commented Feb 13, 2019

The value of 100 is the default from McJtyLib for all scrollable labels, here. You'll want to override it by adding a realmax line just like this realmin line, right next to it:

Edit: Actually, it looks like you can't use code there. Instead, you'll have to call setRealMaximum on it to set it.

@ajthemacboy
Copy link
Author

Everything seems to work, I will be using this in my world... thanks for your help :)

@McJty
Copy link
Collaborator

McJty commented Apr 19, 2019

Sorry for not handling this quickly enough but now it has conflicts because I changed how configs work. Could you fix this? Thanks

@ByPaco10
Copy link

I'll ask a friend of mine to implement this on rftools 1.12 - 7.73, if we have something i'll upload it

@ByPaco10
Copy link

Impossible, the code has changed a lot, we can't do anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request - Increase Environmental Controller radius via config
5 participants