🚨 [security] [ruby] Update nokogiri 1.13.7 → 1.15.6 (minor) #2202

depfu · 2024-03-19T04:07:09Z

🚨 Your current dependencies have known security vulnerabilities 🚨

This dependency update fixes known security vulnerabilities. Please see the details below and assess their impact carefully. We recommend to merge and deploy this as soon as possible!

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

↗️ nokogiri (indirect, 1.13.7 → 1.15.6) · Repo · Changelog

Security Advisories 🚨

🚨 Use-after-free in libxml2 via Nokogiri::XML::Reader

Summary

Nokogiri upgrades its dependency libxml2 as follows:

v1.15.6 upgrades libxml2 to 2.11.7 from 2.11.6

v1.16.2 upgrades libxml2 to 2.12.5 from 2.12.4

libxml2 v2.11.7 and v2.12.5 address the following vulnerability:

CVE-2024-25062 / https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2024-25062

described at https://gitlab.gnome.org/GNOME/libxml2/-/issues/604

patched by https://gitlab.gnome.org/GNOME/libxml2/-/commit/92721970

Please note that this advisory only applies to the CRuby implementation
of Nokogiri, and only if the packaged libraries are being used. If
you've overridden defaults at installation time to use system libraries
instead of packaged libraries, you should instead pay attention to
your distro's libxml2 release announcements.

JRuby users are not affected.

Severity

The Nokogiri maintainers have evaluated this as Moderate.

Impact

From the CVE description, this issue applies to the xmlTextReader
module (which underlies Nokogiri::XML::Reader):

When using the XML Reader interface with DTD validation and
XInclude expansion enabled, processing crafted XML documents
can lead to an xmlValidatePopElement use-after-free.

Mitigation

Upgrade to Nokogiri ~> 1.15.6 or >= 1.16.2.

Users who are unable to upgrade Nokogiri may also choose a more
complicated mitigation: compile and link Nokogiri against patched
external libxml2 libraries which will also address these same issues.

🚨 Update packaged libxml2 to v2.10.4 to resolve multiple CVEs

Summary

Nokogiri v1.14.3 upgrades the packaged version of its dependency libxml2 to
v2.10.4 from v2.10.3.

libxml2 v2.10.4 addresses the following known vulnerabilities:

CVE-2023-29469: Hashing of
empty dict strings isn't deterministic

CVE-2023-28484: Fix null deref
in xmlSchemaFixupComplexType

Schemas: Fix null-pointer-deref in xmlSchemaCheckCOSSTDerivedOK

Please note that this advisory only applies to the CRuby implementation of Nokogiri < 1.14.3,
and only if the packaged libraries are being used. If you've overridden defaults at installation
time to use system libraries instead of packaged libraries, you should instead pay attention to
your distro's libxml2 release announcements.

Mitigation

Upgrade to Nokogiri >= 1.14.3.

Users who are unable to upgrade Nokogiri may also choose a more complicated mitigation: compile
and link Nokogiri against external libraries libxml2 >= 2.10.4 which will also address these
same issues.

Impact

No public information has yet been published about the security-related issues other than the
upstream commits. Examination of those changesets indicate that the more serious issues relate to
libxml2 dereferencing NULL pointers and potentially segfaulting while parsing untrusted inputs.

The commits can be examined at:

[CVE-2023-29469] Hashing of empty dict strings isn't deterministic (09a2dd45)

[CVE-2023-28484] Fix null deref in xmlSchemaFixupComplexType (647e072e)

schemas: Fix null-pointer-deref in xmlSchemaCheckCOSSTDerivedOK (4c6922f7)

🚨 Unchecked return value from xmlTextReaderExpand

Summary

Nokogiri 1.13.8, 1.13.9 fails to check the return value from xmlTextReaderExpand in the method Nokogiri::XML::Reader#attribute_hash. This can lead to a null pointer exception when invalid markup is being parsed.

For applications using XML::Reader to parse untrusted inputs, this may potentially be a vector for a denial of service attack.

Mitigation

Upgrade to Nokogiri >= 1.13.10.

Users may be able to search their code for calls to either XML::Reader#attributes or XML::Reader#attribute_hash to determine if they are affected.

Severity

The Nokogiri maintainers have evaluated this as High Severity 7.5 (CVSS3.1).

References

CWE - CWE-252: Unchecked Return Value (4.9)

CWE - CWE-476: NULL Pointer Dereference (4.9)

Credit

This vulnerability was responsibly reported by @davidwilemski.

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ mini_portile2 (indirect, 2.8.0 → 2.8.5) · Repo · Changelog

Release Notes

2.8.5

2.8.5 / 2023-10-22

Added

New methods #lib_path and #include_path which point at the installed directories under ports. (by @flavorjones)

Add config param for CMAKE_BUILD_TYPE, which now defaults to Release. (#136 by @Watson1978)

Experimental

Introduce experimental support for MiniPortile#mkmf_config which sets up MakeMakefile variables to properly link against the recipe. This should make it easier for C extensions to package third-party libraries. (by @flavorjones)

With no arguments, will set up just $INCFLAGS, $libs, and $LIBPATH.

Optionally, if provided a pkg-config file, will use that config to more precisely set $INCFLAGS, $libs, $LIBPATH, and $CFLAGS/$CXXFLAGS.

Optionally, if provided the name of a static archive, will rewrite linker flags to ensure correct linkage.

Note that the behavior may change slightly before official support is announced. Please comment on #118 if you have feedback.

2.8.4

2.8.4 / 2023-07-18

cmake: set CMAKE compile flags to configure cross-compilation similarly to autotools --host flag: SYSTEM_NAME, SYSTEM_PROCESSOR, C_COMPILER, and CXX_COMPILER. [#130] (Thanks, @stanhu!)

2.8.3

2.8.3 / 2023-07-18

Fixed

cmake: only use MSYS/NMake generators when available. [#129] (Thanks, @stanhu!)

2.8.2

2.8.2 / 2023-04-30

Fixed

Ensure that the source_directory option will work when given a Windows path to an autoconf directory. [#126]

2.8.1

2.8.1 / 2022-12-24

Fixed

Support applying patches via git apply even when the working directory resembles a git directory. [#119] (Thanks, @h0tw1r3!)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 49 commits:

↗️ racc (indirect, 1.6.0 → 1.7.3) · Repo · Changelog

Release Notes

1.7.3

What's Changed

Exclude CRuby extension from JRuby gem by @nobu in #244

Fix for dummy rake/extensiontask.rb at ruby test-bundled-gems by @nobu in #245

Fix jar file path by @nobu in #246

Bump by @nobu in #247

Add srcs target to prepare to build by @nobu in #248

Make CI runnable for any push by @yui-knk in #249

Check rake build on CI by @yui-knk in #250

Bump up v1.7.3.pre.1 by @yui-knk in #251

Fix locations of expect param in docs by @yui-knk in #252

'lib/racc/parser-text.rb' depends on 'lib/racc/info.rb' by @yui-knk in #253

Bump up v1.7.3 by @yui-knk in #254

Full Changelog: v1.7.2...v1.7.3

1.7.2

What's Changed

Update parser.rb, fixed typo by @jwillemsen in #224

Remove leading newline from on_error exception messages. by @zenspider in #226

Add --frozen to add frozen_string_literals to top of generated files. by @zenspider in #225

Update development dependency to avoid ruby 2.5 failures by @flavorjones in #228

dep: pin development dependencies, and enable dependabot for gems by @flavorjones in #229

Clean embedded pragmas by @nobu in #230

Embed grammar file name into generated file by @yui-knk in #231

Bump actions/checkout from 3 to 4 by @dependabot in #232

Fix a typo by @yui-knk in #234

Add "Release flow" to README.rdoc by @yui-knk in #235

Prepare 1.7.2 by @nobu in #236

Remove install guide by setup.rb by @yui-knk in #237

Fix tiny typos by @makenowjust in #238

Remove old checks by @nobu in #240

Remove MANIFEST which was used by ancient extmk.rb by @nobu in #242

Extract Racc::VERSION from racc/info.rb at extconf.rb by @nobu in #241

Use prototype declarations by @nobu in #243

Bump up v1.7.2 by @yui-knk in #239

New Contributors

@makenowjust made their first contribution in #238

Full Changelog: v1.7.1...v1.7.2

1.7.1

What's Changed

Use released version of test-unit-ruby-core by @hsbt in #220

Fix place to specify rake-compiler version by @nobu in #223

Embedded path by @nobu in #221

Full Changelog: v1.7.0...v1.7.1

1.7.0

What's Changed

Update racc.ja document by @hsbt in #207

Make racc Ractor compatible by @pocke in #167

Get rid of anonymous eval calls by @casperisfine in #208

Adds Ruby 3.2 to the CI matrix. by @petergoldstein in #209

Improve actions by @hsbt in #211

Exclude jruby-head on macOS by @flavorjones in #214

Add a newline at EOF [ci skip] by @nobu in #215

[DOC] Strip trailing spaces by @nobu in #216

Add tests for sample dir and tweak samples by @hkdnet in #217

Remove ErrorSymbolValue reference by @jeremyevans in #213

Embed racc/info.rb too by @nobu in #218

New Contributors

@petergoldstein made their first contribution in #209

@hkdnet made their first contribution in #217

@jeremyevans made their first contribution in #213

Full Changelog: v1.6.2...v1.7.0

1.6.2

What's Changed

Fixed typo in racc.en.rhtml by @jwillemsen in #200

Removed old Id tag by @jwillemsen in #204

Removed old originalId in comment by @jwillemsen in #203

Adjust Racc parser version with gem version. by @hsbt in #205

Full Changelog: v1.6.1...v1.6.2

1.6.1

What's Changed

CI: Add JRuby 9.3, use bundler-cache by @olleolleolle in #173

Fix names by @nobu in #178

Update README.rdoc by @jwillemsen in #179

s/RubyVM::JIT/RubyVM::MJIT/g by @k0kubun in #180

ci: update to cover Ruby 3.1 by @flavorjones in #181

Fix typo in sample/calc.y. by @simi in #184

Added dependabot.yml for actions by @hsbt in #186

Bump actions/checkout from 2 to 3 by @dependabot in #187

[DOC] Remove stale Object::ParseError documentation by @nobu in #188

Strip trailing spaces by @nobu in #189

Fix flag to Regexp.new by @nobu in #191

Fix documentation directory name in README by @okuramasafumi in #193

Make racc test more flexible (for JRuby). by @enebo in #194

Update racc.en.rhtml by @jwillemsen in #195

Update README.rdoc by @jwillemsen in #196

Update racc.gemspec by @jwillemsen in #197

ci: update jruby versions and add truffleruby by @flavorjones in #198

New Contributors

@jwillemsen made their first contribution in #179

@k0kubun made their first contribution in #180

@simi made their first contribution in #184

@dependabot made their first contribution in #187

@okuramasafumi made their first contribution in #193

Full Changelog: v1.6.0...v1.6.1

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands

@depfu rebase
Rebases against your default branch and redoes this update

@depfu recreate
Recreates this PR, overwriting any edits that you've made to it

@depfu merge
Merges this PR once your tests are passing and conflicts are resolved

@depfu cancel merge
Cancels automatic merging of this PR

@depfu close
Closes this PR and deletes the branch

@depfu reopen
Restores the branch and reopens this PR (if it's closed)

@depfu pause
Ignores all future updates for this dependency and closes this PR

@depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR

@depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

codecov · 2024-03-19T04:12:12Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.44%. Comparing base (bc30b17) to head (c9fba43).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2202      +/-   ##
==========================================
+ Coverage   71.42%   71.44%   +0.01%     
==========================================
  Files          87       87              
  Lines        6293     6293              
  Branches      884      884              
==========================================
+ Hits         4495     4496       +1     
+ Misses       1457     1456       -1     
  Partials      341      341

see 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc30b17...c9fba43. Read the comment docs.

depfu · 2024-05-13T18:09:16Z

Closed in favor of #2219.

Update nokogiri to version 1.15.6

c9fba43

depfu bot added the depfu label Mar 19, 2024

depfu bot closed this May 13, 2024

depfu bot deleted the depfu/update/nokogiri-1.15.6 branch May 13, 2024 18:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🚨 [security] [ruby] Update nokogiri 1.13.7 → 1.15.6 (minor) #2202

🚨 [security] [ruby] Update nokogiri 1.13.7 → 1.15.6 (minor) #2202

depfu bot commented Mar 19, 2024

codecov bot commented Mar 19, 2024

depfu bot commented May 13, 2024

🚨 [security] [ruby] Update nokogiri 1.13.7 → 1.15.6 (minor) #2202

🚨 [security] [ruby] Update nokogiri 1.13.7 → 1.15.6 (minor) #2202

Conversation

depfu bot commented Mar 19, 2024

What changed?

↗️ nokogiri (indirect, 1.13.7 → 1.15.6) · Repo · Changelog

Summary

Severity

Impact

Mitigation

Summary

Mitigation

Impact

Summary

Mitigation

Severity

References

Credit

↗️ mini_portile2 (indirect, 2.8.0 → 2.8.5) · Repo · Changelog

2.8.5 / 2023-10-22

Added

Experimental

2.8.4 / 2023-07-18

2.8.3 / 2023-07-18

Fixed

2.8.2 / 2023-04-30

Fixed

2.8.1 / 2022-12-24

Fixed

↗️ racc (indirect, 1.6.0 → 1.7.3) · Repo · Changelog

What's Changed

What's Changed

New Contributors

What's Changed

What's Changed

New Contributors

What's Changed

What's Changed

New Contributors

codecov bot commented Mar 19, 2024

Codecov Report

depfu bot commented May 13, 2024