Skip to content

Commit

Permalink
flyteorg#5085 Remove useless comments
Browse files Browse the repository at this point in the history
Signed-off-by: Mecoli1219 <[email protected]>
  • Loading branch information
Mecoli1219 committed May 7, 2024
1 parent 6f8343d commit 7b8bb21
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 6 deletions.
2 changes: 0 additions & 2 deletions flyteplugins/go/tasks/pluginmachinery/core/exec_metadata.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ import (
)

// TaskOverrides interface to expose any overrides that have been set for this task (like resource overrides etc)
//
//go:generate mockery -name TaskOverrides -case underscore
type TaskOverrides interface {
GetResources() *v1.ResourceRequirements
GetExtendedResources() *core.ExtendedResources
Expand Down
1 change: 0 additions & 1 deletion flytepropeller/pkg/apis/flyteworkflow/v1alpha1/nodes.go
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ func (in *ExtendedResources) DeepCopyInto(out *ExtendedResources) {
// Once we figure out the autogenerate story we can replace this
}

//go:generate mockery -name ExecutableNode -output=mocks
type NodeSpec struct {
ID NodeID `json:"id"`
Name string `json:"name,omitempty"`
Expand Down
2 changes: 0 additions & 2 deletions flytepropeller/pkg/compiler/transformers/k8s/node.go
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
package k8s

import (
"context"
"github.com/flyteorg/flyte/flytestdlib/logger"
"strings"

"github.com/go-test/deep"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ func newTaskExecutionMetadata(tCtx pluginsCore.TaskExecutionMetadata, taskTmpl *
var err error
secretsMap := make(map[string]string)
injectLabels := make(map[string]string)
// TODO: Why it couldn't get anything???
if tCtx.GetOverrides().GetOverrideSecurityContext() != nil {
if len(tCtx.GetOverrides().GetOverrideSecurityContext().GetSecrets()) > 0 {
secretsMap, err = secrets.MarshalSecretsToMapStrings(tCtx.GetOverrides().GetOverrideSecurityContext().GetSecrets())
Expand Down

0 comments on commit 7b8bb21

Please sign in to comment.