Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update file extensions lists #967

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Update file extensions lists #967

merged 1 commit into from
Nov 18, 2024

Conversation

cjee21
Copy link
Collaborator

@cjee21 cjee21 commented Nov 18, 2024

No description provided.

Copy link
Member

@JeromeMartinez JeromeMartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a file extension should be done on all GUIs and platforms, please update at the same time Source\Common\Preferences.cpp, Source\GUI\Cocoa\MediaInfo-Info.plist, Source\GUI\UWP\Package.appxmanifest, Source\Install\MediaInfo_Extensions.nsh.

@JeromeMartinez
Copy link
Member

I saw #960 (comment) too late. Lists should be same everywhere.

@cjee21
Copy link
Collaborator Author

cjee21 commented Nov 18, 2024

I saw #960 (comment) too late. Lists should be same everywhere.

I will try to see if I can come up with a way to auto generate all the lists from a single list. To ensure all are the same and make it easier to edit the lists next time.

@JeromeMartinez
Copy link
Member

I will try to see if I can come up with a way to auto generate all the lists from a single list.

Would be nice.

@cjee21
Copy link
Collaborator Author

cjee21 commented Nov 18, 2024

@JeromeMartinez Need to do something about the audio video thing.

In installer there is:
!insertmacro MediaInfo_Extensions_Uninstall_I "audio"
!insertmacro MediaInfo_Extensions_Uninstall_I "Folder"
!insertmacro MediaInfo_Extensions_Uninstall_I "video"

In Preferences.cpp there is:
ExplorerShell_Edit("Software\Classes\Directory", Config.Read(__T("ShellExtension_Folder")).To_int32s(), IsChanged);

So Folder and Directory is mismatch as well as Preferences.cpp list no audio and video. Also, the Preferences.cpp code is not correctly removing the audio and video entries added by installer when user chooses to disable the shell extension.

@cjee21 cjee21 changed the title Qt GUI: Add more file extensions to MSIX manifest Update file extensions lists Nov 18, 2024
@cjee21
Copy link
Collaborator Author

cjee21 commented Nov 18, 2024

Done matching all except Source\GUI\Cocoa\MediaInfo-Info.plist since the list is split in there so I do not know what goes where and what is missing.

Here is the spreadsheet that can auto-generate the lists:
MediaInfo_fileextensions.xlsx

@JeromeMartinez JeromeMartinez merged commit 577481b into MediaArea:master Nov 18, 2024
3 checks passed
@JeromeMartinez
Copy link
Member

So Folder and Directory is mismatch as well as Preferences.cpp list no audio and video. Also, the Preferences.cpp code is not correctly removing the audio and video entries added by installer when user chooses to disable the shell extension.

Oops... If I understand correctly this post, I should uninstall "Folder" and install "Directory", and let the CPP as is.

@JeromeMartinez
Copy link
Member

So Folder and Directory is mismatch as well as Preferences.cpp list no audio and video. Also, the Preferences.cpp code is not correctly removing the audio and video entries added by installer when user chooses to disable the shell extension.

I should read all notifications before answering, now seeing #968, thanks!

@cjee21 cjee21 deleted the Qt branch November 18, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants