-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update file extensions lists #967
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a file extension should be done on all GUIs and platforms, please update at the same time Source\Common\Preferences.cpp
, Source\GUI\Cocoa\MediaInfo-Info.plist
, Source\GUI\UWP\Package.appxmanifest
, Source\Install\MediaInfo_Extensions.nsh
.
I saw #960 (comment) too late. Lists should be same everywhere. |
I will try to see if I can come up with a way to auto generate all the lists from a single list. To ensure all are the same and make it easier to edit the lists next time. |
Would be nice. |
@JeromeMartinez Need to do something about the audio video thing. In installer there is: In Preferences.cpp there is: So Folder and Directory is mismatch as well as Preferences.cpp list no audio and video. Also, the Preferences.cpp code is not correctly removing the audio and video entries added by installer when user chooses to disable the shell extension. |
Done matching all except Here is the spreadsheet that can auto-generate the lists: |
Oops... If I understand correctly this post, I should uninstall "Folder" and install "Directory", and let the CPP as is. |
I should read all notifications before answering, now seeing #968, thanks! |
No description provided.