feat: special negative-conditional cache for two properties that are …

…very important for Princess calculations
MegaMek · Jan 30, 2025 · 18a8f95 · 18a8f95
1 parent 2015dac
commit 18a8f95
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 5 deletions.
diff --git a/megamek/src/megamek/common/Entity.java b/megamek/src/megamek/common/Entity.java
@@ -899,6 +899,7 @@ public enum InvalidSourceBuildReason {
 
     private boolean hasFleeZone = false;
     private HexArea fleeZone = HexArea.EMPTY_AREA;
+    private transient Boolean cacheHasNoModularArmor = null;
 
     /**
      * Generates a new, blank, entity.
@@ -6447,6 +6448,7 @@ public void newRound(int roundNumber) {
         isJumpingNow = false;
         convertingNow = false;
         damageThisRound = 0;
+        cacheHasNoModularArmor = null;
         if (assaultDropInProgress == 2) {
             assaultDropInProgress = 0;
         }
@@ -12131,7 +12133,10 @@ public boolean isAeroSensorDestroyed() {
     }
 
     public boolean hasModularArmor() {
-        return hasModularArmor(-1);
+        if (cacheHasNoModularArmor == null || cacheHasNoModularArmor) {
+            cacheHasNoModularArmor = hasModularArmor(-1);
+        }
+        return cacheHasNoModularArmor;
     }
 
     public boolean hasModularArmor(int loc) {

diff --git a/megamek/src/megamek/common/Mek.java b/megamek/src/megamek/common/Mek.java
@@ -318,6 +318,8 @@ public abstract class Mek extends Entity {
     // Cooling System Flaws quirk
     private boolean coolingFlawActive = false;
 
+    private transient Boolean cacheHasNoIndustrialTSM = null;
+
     // QuadVees, LAMs, and tracked 'Meks can change movement mode.
     protected EntityMovementMode originalMovementMode = EntityMovementMode.BIPED;
 
@@ -610,6 +612,7 @@ public void newRound(int roundNumber) {
                 m.setMode("Off");
             }
         } // Check the next piece of equipment.
+        cacheHasNoIndustrialTSM = null;
 
         super.newRound(roundNumber);
         incrementMASCAndSuperchargerLevels();
@@ -885,13 +888,19 @@ public boolean hasActiveTSM(boolean includeIndustrial) {
      * @return
      */
     public boolean hasIndustrialTSM() {
-        for (Mounted<?> m : getEquipment()) {
-            if ((m.getType() instanceof MiscType)
+        // This is a special cache that returns immediatelly if the value is false
+        // but checks for the real value if it is not (because it may lose the state, but cannot gain during normal gameplay)
+        if (cacheHasNoIndustrialTSM == null || cacheHasNoIndustrialTSM) {
+            for (Mounted<?> m : getEquipment()) {
+                if ((m.getType() instanceof MiscType)
                     && m.getType().hasFlag(MiscType.F_INDUSTRIAL_TSM)) {
-                return true;
+                    cacheHasNoIndustrialTSM = true;
+                    return true;
+                }
             }
+            cacheHasNoIndustrialTSM = false;
         }
-        return false;
+        return cacheHasNoIndustrialTSM;
     }
 
     /**