From StringBuilder to Logger #6462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leaner memory profile and faster run
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6462 +/- ##
============================================
- Coverage 28.59% 28.56% -0.03%
+ Complexity 14377 14373 -4
============================================
Files 2798 2798
Lines 274895 275068 +173
Branches 48630 48664 +34
============================================
- Hits 78593 78578 -15
- Misses 191669 191855 +186
- Partials 4633 4635 +2 ☔ View full report in Codecov by Sentry. |
Sleet01
reviewed
Jan 30, 2025
| (Mek.LOC_CT == loc) || | ||
| (ProtoMek.LOC_HEAD == loc) || | ||
| (ProtoMek.LOC_TORSO == loc) || | ||
| !(movingUnit.isMek() && !(movingUnit.isProtoMek())) |
There was a problem hiding this comment.
I believe the first ! must go inside the parentheses; this new construction will evaluate to true if the unit is a ProtoMek, but previously it would only evaluate to true if the unit is not a Mek and not a ProtoMek.
Sleet01
requested changes
Jan 30, 2025
Scoppio
commented
Jan 31, 2025
| logMsg.append(" breached and critical (1000)."); | ||
| if ((Mek.LOC_HEAD == loc) || | ||
| (Mek.LOC_CT == loc) || | ||
| (ProtoMek.LOC_HEAD == loc) || |
Check warning
Code scanning / CodeQL
Useless comparison test Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using logging trace level for all this stuff instead of debug because it really is a level lower than debug what it is doing.
Kept the reasoning in the RankedPath as it is a great tool to understand what happened to select that object, but other than that, not much was changed in code.