Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MegaMekLab Issue 1662: Fixed issue with Mek exporting to text #6507

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

psikomonkie
Copy link
Collaborator

@psikomonkie psikomonkie commented Feb 6, 2025

Fixes MegaMek/megameklab#1662

<#if riscKit> was throwing an error when a null value for riscKit was provided. This lets it work properly if riscKit is null.

This is handled the same way in mek.ftlh, line 39

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.55%. Comparing base (9bf6d6e) to head (82be9b7).
Report is 17 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6507      +/-   ##
============================================
- Coverage     28.55%   28.55%   -0.01%     
+ Complexity    14465    14464       -1     
============================================
  Files          2815     2815              
  Lines        277309   277309              
  Branches      48973    48973              
============================================
- Hits          79175    79173       -2     
- Misses       193434   193435       +1     
- Partials       4700     4701       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Sleet01 Sleet01 merged commit df7166f into MegaMek:master Feb 7, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export to clipboard isn't works at all.
2 participants