-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(DRAFT) Finishing Profession Unit Testing #3587
base: master
Are you sure you want to change the base?
(DRAFT) Finishing Profession Unit Testing #3587
Conversation
Codecov ReportBase: 10.67% // Head: 10.68% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3587 +/- ##
============================================
+ Coverage 10.67% 10.68% +0.01%
- Complexity 5467 5478 +11
============================================
Files 829 829
Lines 113349 113349
Branches 17094 17094
============================================
+ Hits 12096 12112 +16
+ Misses 100046 100029 -17
- Partials 1207 1208 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to not let this stew again.
I have about 0% XP on unit tests but I think I read you can prepend initialization to every test using something like @beforeall on an init method. The start of the tests looks very similar, maybe this is something to simplify, for what it's worth.
The minor differences required for the tests unfortunately make that impossible. Also, this is still a draft |
This is the last of the personnel enums to do