Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wordWrap Method from RandomMarriageMethod, RandomProcreationMethod, RandomDivorceMethod Classes #4964

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

IllianiCBT
Copy link
Collaborator

Removed the unutilized wordWrap method from RandomMarriageMethod, RandomProcreationMethod, and RandomDivorceMethod. Updated corresponding unit tests to reflect these changes for improved readability and maintainability.

I'm about to push some changes to the wordWrap method which will cause these tests to break, if wordWrap isn't removed.

Removed the unutilized wordWrap method from RandomMarriageMethod, RandomProcreationMethod, and RandomDivorceMethod. Updated corresponding unit tests to reflect these changes for improved readability and maintainability.
@IllianiCBT IllianiCBT added Bug Tests Issues or Pull Requests related to the project tests labels Oct 2, 2024
@IllianiCBT IllianiCBT self-assigned this Oct 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.47%. Comparing base (bae1257) to head (415ecaf).
Report is 19 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4964      +/-   ##
============================================
- Coverage     10.48%   10.47%   -0.01%     
+ Complexity     6027     6021       -6     
============================================
  Files           951      951              
  Lines        133247   133248       +1     
  Branches      19382    19377       -5     
============================================
- Hits          13971    13961      -10     
- Misses       117926   117940      +14     
+ Partials       1350     1347       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Introduced a turning points dialog with comprehensive descriptions and selectable dates. This was a feature suggested by user feedback.
@HammerGS HammerGS merged commit 5caa781 into MegaMek:master Oct 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Tests Issues or Pull Requests related to the project tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants