Add FlatLaf GUi scaling to MHQ #4990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuronekochomusuke
approved these changes
Oct 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4990 +/- ##
============================================
- Coverage 10.46% 10.44% -0.02%
+ Complexity 6022 6009 -13
============================================
Files 951 950 -1
Lines 133345 133437 +92
Branches 19378 19383 +5
============================================
- Hits 13955 13944 -11
- Misses 118041 118142 +101
- Partials 1349 1351 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds FlatLaf's GUI scaling to MHQ. It shares the scale value with MM and MML, i.e. changing it in one program changes it for the others too. The scale is set in the MekHQ options, display. This PR also removes hardcoded GUI sizes where they interfere with scaling. There are certain to be some mis-sized elements left but generally it seems to work well.