Add Customization Option to Refit Dialog #4992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a refit kit is easier than and has different rules from customizing a mek, and until now the only way to use the customization rules was to use the meklab manually. This setup also allows you to customize a mek to a non-canon variant but only refit to a canon variant if canon-refits-only is turned on. This means that when that option is enabled it is much easier to repeat saved meklab customizations. This further means that building mek variants in MegaMekLab and then carrying out the customization as if you had done it inside MekHQMekLab is possible. Utilities.getAllVariants was changed but that function only has the code we're working on here calling it.
|
Thank you for this contribution and welcome to the project! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4992 +/- ##
============================================
+ Coverage 10.46% 10.47% +0.01%
- Complexity 6022 6029 +7
============================================
Files 951 950 -1
Lines 133345 133395 +50
Branches 19378 19383 +5
============================================
+ Hits 13955 13974 +19
- Misses 118041 118077 +36
+ Partials 1349 1344 -5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a refit kit is easier than and has different rules from customizing a mek, and until now the only way to use the customization rules was to use the meklab manually.
This setup allows you to use the customization rules to change mek to a any available variant without using the meklab tab, even when refit-to-canon-units-only is on. This means you can do more without using the meklab tab, and that customizing units in MegaMekLab externally is more viable in more scenarios.
Utilities.getAllVariants was changed but it's a single-client function.
As a bonus, the refit dialog now resizes a little better, with the mek view panels now enlarging with the window size.
This screenshot shows how only customize is available when the refit-to-canon-units-only option is turned on.