Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Current Location / Travel Status #5022

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

WeaverThree
Copy link
Contributor

A new style of Current Location info line that reads better and gives a little better info.

Better Travel Text

Pros of new format:

  • Shows remaining jumps
  • Shows travel time to jump point instead of travel time from planet when outbound
  • Supports planets with different names than their system.
  • Clarifies that the jumpship is what's being charged

Cons:

  • No longer shows jumpship charge unless you're waiting at jumppoint

Wish I could:

  • Show total days remaining in trip

Stylistic:

  • Doesn't use any italics anymore

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.46%. Comparing base (4e72790) to head (f443c36).
Report is 28 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5022      +/-   ##
============================================
- Coverage     10.47%   10.46%   -0.01%     
+ Complexity     6029     6028       -1     
============================================
  Files           950      950              
  Lines        133397   133415      +18     
  Branches      19384    19386       +2     
============================================
- Hits          13974    13966       -8     
- Misses       118076   118101      +25     
- Partials       1347     1348       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS HammerGS merged commit 561d941 into MegaMek:master Oct 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants