New names cleanup and potential bugfixes #5043
Conversation
Kludge to handle blank model names in populateRefit()
Makes the refit GUI properly query for duplicates using the new naming scheme. Changes the filenames of custom refits to follow the "IS name (clan name) model.mtf" scheme. Refactoring of the file output code in preparation for future changes. Refactoring to remove retrieveOriginalUnit(Entity newE) and properly use refreshUnitData() instead of loadMekData to refresh the cache after saving new custom refits.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Also, this is approved pending the JavaDoc error being fixed |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5043 +/- ##
=========================================
Coverage 10.43% 10.43%
- Complexity 6022 6027 +5
=========================================
Files 952 952
Lines 133810 133861 +51
Branches 19432 19429 -3
=========================================
+ Hits 13961 13969 +8
- Misses 118498 118547 +49
+ Partials 1351 1345 -6 ☔ View full report in Codecov by Sentry. |
"It works on my machine" |
|
That was my assumption, but I’ve learned not to assume. When this gets merged let’s flag it with the QA folks so they know to test it, speaking of which I should probably give you to contributor role on Discord… |
That should be the last of MekHQ updated to follow the new "IS name (clan name) model" naming scheme. MM and MML still have some bits.
Please excuse the funny list of commits, only bd0e259 is actually new.
This will prevent custom refits of clan units from reusing already taken model names. I don't think that bug was reported though.
The change from
loadMekData()torefreshUnitData()might help with #4554 and potentially fix #4791 but I haven't tested either and the proper way for the former would still be to enable the (un)loading of a single specified file.The rest is some incidental cleanup and refactoring to prepare for implementing #4978