Split graphs #27
Merged
Split graphs #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed edges - Add 'eliminar dispositivo' button in the right-bar for user interaction - Need to review deletion optimization and modularize showInfo method
…ataGraph - Made `Edge` instances clickable and added `showInfo` method to display edge information in the right bar. - Implemented an interactive "Delete Edge" button in `showInfo` for each edge to allow users to remove edges individually. - Added `removeEdge` method in `ViewGraph` to handle the removal of edges, updating connected devices and cleaning up graphical resources. - Added `removeEdge` method in `DataGraph` to remove connections between two specific devices by their IDs, ensuring mutual disconnection. - Updated edge drawing to make the lines red and improved precision by limiting decimal points in displayed positions. - Refactored `drawEdge` method to accept `startPos` and `endPos` as parameters for flexibility in updating edge positions. TODO: Review and optimize edge deletion and modularize.
MegaRedHand
approved these changes
Nov 6, 2024
- Moved ViewGraph construction logic to be self-contained, as each layer will have its own view. - Added a TODO comment in the `constructView` method to indicate a future dependency on the selected layer. - Set `eventMode` to "static" and `interactive` to `true` for devices, and added `addChild` from the callers, as suggested for consistency. - Moved logic for edge creation and management into the `Edge` class to centralize functionality and improve modularity. These changes address code structure improvements and prepare for future layer-based functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split Graphs
This update divides the graph functionality into two distinct components: DataGraph and ViewGraph.
DataGraph is solely responsible for maintaining the entire network’s information, while ViewGraph handles the creation, updating, and removal of device and edge drawings in the view.
Additionally, this update introduces new features:
Closes #16
Closes #20