Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MemoEdit: include border size when autosizing #5952

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

stsrki
Copy link
Collaborator

@stsrki stsrki commented Jan 24, 2025

Fixes problem with auto size showing the scrollbar

Another question: We have the issue that a memoedit with Autosize=”true” shows a scrollbar. Its height is a few pixels too small. This is especially a problem because the scrollbar hides the green check-mark of a validation in the top right corner. I saw this has been an issue in an earlier version of Blazorise and has been fixed. Is it possible this issue has been re-introduced in 1.7?

Test code:

<Div>
    <MemoEdit Text="@memoText"
              Size="Size.Small"
              TextWeight="TextWeight.Light"
              ReplaceTab="true"
              AutoSize="true"
              Overflow="Overflow.Auto"
              ReadOnly="false">
    </MemoEdit>
</Div>

<Button Clicked="SetText">Set Text</Button>
@code {
    private string memoText;

    private void SetText()
    {
        var emp = new Employee { Id = 1, FirstName = "Alexander Maximilian", LastName = "Hohenberg Von Strassburg", Email = "[email protected]", City = "Berlin", Zip = "10115", DateOfBirth = new DateTime(1985, 5, 15), Childrens = 2, Salary = 50000, IsActive = true };

        var options = new JsonSerializerOptions();

        options.WriteIndented = true;

        memoText = System.Text.Json.JsonSerializer.Serialize(emp, options);
    }
}

@stsrki stsrki requested a review from tesar-tech January 24, 2025 10:17
Source/Blazorise/wwwroot/memoEdit.js Outdated Show resolved Hide resolved
@stsrki stsrki requested a review from tesar-tech January 27, 2025 08:58
@stsrki stsrki changed the title MemoEdit: add few pixels to fix clipping MemoEdit: include border size when autosizing Jan 27, 2025
@stsrki stsrki merged commit c1c82f3 into rel-1.7 Jan 27, 2025
2 checks passed
@stsrki stsrki deleted the rel-1.7-memoedit-fix-clipping branch January 27, 2025 11:29
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants