hw-mgmt: scripts: Fix creation and removal of psuN_i2c_bus files #1554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These files are created when PSU cables are plugged in and removed when PSU cable are plugged out. Instead, they should be created and removed when PSUs are plugged in and plugged out respectively. Otherwise there is no way to distingush between dummy PSU and real PSU that was disconnected from power. Bug: 4176785 Signed-off-by: Felix Radensky <[email protected]>
felixradensky
requested review from
sholeksandr,
ciju-nvidia,
mshych and
vadimp-nvidia
as code owners
sholeksandr
previously approved these changes
Jan 16, 2025
mshych
reviewed
Jan 16, 2025
| fi | ||
| find_i2c_bus | ||
| i2c_comex_mon_bus_default=$(< $i2c_comex_mon_bus_default_file) | ||
| comex_bus=$((i2c_comex_mon_bus_default+i2c_bus_offset)) |
There was a problem hiding this comment.
I just wonder if we can receive such event with comex_i2c_bus.
Maybe this check is not required.
There was a problem hiding this comment.
This code was copied from hw-management-thermal-events.sh It was added by Vadim in this commit: be275d9. There are many places where comex_i2c_bus is checked
|
RERUN |
|
RERUN |
felixradensky
force-pushed
the
V.7.0040.3000_BR_PSU
branch
from
98efcc7 to
4f9e9cf
Compare
|
RERUN |
acoifmannvidia
approved these changes
Jan 19, 2025
|
RERUN |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These files are created when PSU cables are plugged in and removed when PSU cable are plugged out. Instead, they should be created and removed when PSUs are plugged in and plugged out respectively. Otherwise there is no way to distingush between dummy PSU and real PSU that was disconnected from power.
Bug: 4176785