Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: replace MOFED to DOCA on API docs #1332

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

rollandf
Copy link
Member

@rollandf rollandf commented Feb 12, 2025

  • The fix is only for the API docs that are reflected in official documentation
  • API fields are not changed to not break API

@coveralls
Copy link
Collaborator

coveralls commented Feb 13, 2025

Pull Request Test Coverage Report for Build 13289523128

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.09%) to 59.641%

Files with Coverage Reduction New Missed Lines %
controllers/ipoibnetwork_controller.go 5 77.38%
Totals Coverage Status
Change from base Build 13235870136: -0.09%
Covered Lines: 3325
Relevant Lines: 5575

💛 - Coveralls

Copy link
Collaborator

@heyvister1 heyvister1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming CRD manifest changes were generated and not changed inline

@rollandf
Copy link
Member Author

Assuming CRD manifest changes were generated and not changed inline

Yes. There is also a check checking the manifests are updated: https://github.com/Mellanox/network-operator/blob/master/.github/workflows/checks.yaml#L52

@rollandf rollandf merged commit 0275f59 into Mellanox:master Feb 13, 2025
18 checks passed
rollandf added a commit that referenced this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants