module_prefix for adjusting interface file (hi/dyn_hi) path #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aherrmann
reviewed
Jan 7, 2025
There was a problem hiding this comment.
How did the issue manifest? Is it causing build errors, or is it a user interface issue with the generated per-module sub-targets?
I'm asking because we infer source prefixes dynamically, see #26, which replaced the previous source prefix stripping attribute, see #23. One motivation for automatic inference was support for multiple source directories, see #31. I think the prefix added here should not be an issue for multiple source dirs, since they would all share a common prefix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If BUCK file is located inside a package source tree, then the earlier part of module source paths are truncated, and thus the resultant pkg.conf will have wrong information.
Though it is desirable to get correct module names, they are only correctly available as a result of parsing, i.e. needs to be implemented as dynamic values, which can complicate the situation. So for now (or forever), I assume that user can provide module prefix for that target without difficulty. Interface path is then adjusted with the prefix.