Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support new wisp specifications #7

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

feat: support new wisp specifications #7

wants to merge 16 commits into from

Conversation

builtbyvys
Copy link
Member

this pull request supports the new wisp specifications

@builtbyvys builtbyvys added the enhancement New feature or request label Jun 28, 2024
@builtbyvys
Copy link
Member Author

it is important to note that auth isn't fully supported yet at this time

@builtbyvys builtbyvys marked this pull request as draft June 28, 2024 17:28
@ading2210
Copy link
Member

Why did you change the indentation on every single file from 4 to 2 spaces?

ading2210
ading2210 requested changes Jun 29, 2024
View reviewed changes
Copy link
Member

@ading2210 ading2210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the indentation.

@ading2210
Copy link
Member

Also Wisp v2 isn't official yet, so there's no point merging this right now.

@builtbyvys
Copy link
Member Author

Why did you change the indentation on every single file from 4 to 2 spaces?

sorry, I think I forgot to relint before pushing the commit

@builtbyvys
Copy link
Member Author

Please fix the indentation.

will do when I have the time later today

@builtbyvys builtbyvys marked this pull request as ready for review June 29, 2024 13:42
@builtbyvys builtbyvys marked this pull request as draft June 29, 2024 13:43
@builtbyvys builtbyvys requested a review from ading2210 July 6, 2024 05:38
builtbyvys
builtbyvys commented Jul 25, 2024
View reviewed changes
Copy link
Member Author

@builtbyvys builtbyvys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue with the "pretty" script that'd fail to run due to LICENSE not being ignored (as there's no .prettierignore)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ading2210 ading2210 Awaiting requested review from ading2210

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@builtbyvys @ading2210 @Percslol @ProgrammerIn-wonderland