Framework agnostic approach #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 23, 2024 13:44
…amework library, small docblock updates, removed unused imports
…amework library, small docblock updates, removed unused imports
denisvanmorgan
commented
Jan 23, 2024
| @@ -45,13 +41,4 @@ private function getDriverOptions(bool $isMainNet): array | |||
| ?: $this->mainnet | |||
| ?: []; | |||
| } | |||
|
|
|||
| public static function __set_state(array $state): DriverConfig | |||
There was a problem hiding this comment.
seems like there is not usage for this magic method in a code anymore. feel free to correct me if I missed something
denisvanmorgan
commented
Jan 23, 2024
| } | ||
|
|
||
| public static function make(CurrencyEnum $currency): Validator | ||
| public static function make(CurrencyEnum $currency, bool $isMainnet = true, ?array $config = null): self |
There was a problem hiding this comment.
since this factory method copies current construct method I was thinking if it would make sense to remove it. But I left it here for backwards compatibility reasons. Maybe we can docblock it with @deprecated to encourage developers to use constructor instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
we are using your package in our project to validate crypto addresses on our infrastructure layer for our request DTOs. Thank you for maintaining this project, so far we were really happy to work with it.
We decided to upgrade our dependencies but this one kept throwing composer error messages from version 2.0.X. So I checked it and it seems that the package is tightly coupled with laravel/framework package. Which is quite unfortunate if you want to use it as a standalone package in your non-framework project or project where you use Symfony, Nette, Yii, CakePHP etc. I must say that it's not desirable to fetch whole laravel/framework lib because of few lines of code.
So I made some changes to make things more flexible and make it possible for other people to use the package however they want.
So it can be used right now like this:
Validator::make('BTC', app()->isProduction())or
Validator::make('BTC', $this->featureFlag->isTestnet())etc, etc.
If you have any questions feel free to hit me up.