Return assets to initiator if cancelled at the stage of Initiation

[leomayleomay]

Summary

Return the assets to initiator when cancelled at the stage of Initiation, otherwise the assets will be locked forever

Affect components

Please indicate which part of the Mesh Repo

• @meshsdk/common
• @meshsdk/contract
• @meshsdk/core
• @meshsdk/core-csl
• @meshsdk/core-cst
• @meshsdk/provider
• @meshsdk/react
• @meshsdk/svelte
• @meshsdk/transaction
• @meshsdk/wallet
• Mesh playground (i.e. https://meshjs.dev/)
• Mesh CLI

Type of Change

Please mark the relevant option(s) for your pull request:

• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Bug fix (non-breaking change which fixes an issue)
• Code refactoring (improving code quality without changing its behavior)
• Documentation update (adding or updating documentation related to the project)

Related Issues

Please add the related issue here if any

Checklist

Please ensure that your pull request meets the following criteria:

• My code is appropriately commented and includes relevant documentation, if necessary
• I have added tests to cover my changes, if necessary
• I have updated the documentation, if necessary
• All new and existing tests pass (i.e. npm run test)
• The build is pass (i.e. npm run build)

Additional Information

If you have any additional information or context to provide, such as screenshots, relevant issues, or other details, please include them here.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
mesh-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 22, 2025 11:24am

[vercel]

@leomayleomay is attempting to deploy a commit to the MeshJS Team on Vercel.

A member of the Team first needs to authorize it.

[HinsonSIDAN]

Thank you for your contribution! The output value check is indeed intentionally ignored since it is implicitly guarded.

Imagine you are the escrow creator and you want to cancel, since you are building the tx to cancel, the value locked would implicitly going to your change address.

This unguarded pattern is also intentionally implemented so that to prevent permanent lock of circulation due to careless offchain construction at initiation.

Thus, the change would not be merged. But we do appreciate your attempt. Alternatively you can revert the change and add a comment on this pattern and i would approve the PR accordingly, otherwise i would discard this PR.