Feature/state read #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mo-joshuacolclough
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Thanks! State reading capability tested with lfric-jedi here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few tweaks and alterations as part of the use of
Monio::stateReadfrom LFRic-JEDI. Fixed an issue where input file was closed and not reopened when accessed multiple times. Changed the derivation of the "naming convention" from input files (for increment and state read). Not all files contain this metadata field, in which case the assumption is that the data adopt LFRic naming. Added additional error checking in AtlasWriter (as suggested by @mo-joshuacolclough).Current test outputs: http://fcm1/cylc-review/taskjobs/punderwo/?suite=monio_state_read_01