Feature/file closure #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ture/open_source
…n appropriate places.
There was a problem hiding this comment.
Looks good. Had one comment.
Tests (all_ctest): http://fcm1/cylc-review/cycles/jcolclou/?suite=monio_26__201023
mo-joshuacolclough
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reinstated file closures following exceptions. Temporarily taken out as it seemed to be causing issues during some tests when run interactively. It's presumed a brace was missing somewhere that caused files to close before they were finished with.
Current test outputs: http://fcm1/cylc-review/taskjobs/punderwo/?suite=monio_file_closure_04