-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update ci workflow #35
Conversation
I anticipate the manual workflow to work okay with manual trigger, but cant be tested until merged in develop. I may need to open a follow-up PR in case the manual workflow proves problematic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sensible.
@phlndrwd note that monio tests still depend on legacy lfric-lite test data. Worth moving them to monio's own test suite or use cases from lfric-jedi instead? |
Thanks @yaswant. I guess this would be a trade-off between when the legacy data is due to disappear and when XIOS is expected to take-over from MONIO. If there is significant overlap then I don't think it would be worth making any significant changes here. Though I'm not in a position to answer this alone so it might be a conversation to be had with @odlomax, @matthewrmshin, & @mo-joshuacolclough, et al. |
Update CI workflows
Example build group annotation
build-group=JCSDA-internal/oops#2714