Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ci workflow #35

Merged
merged 13 commits into from
Aug 6, 2024
Merged

update ci workflow #35

merged 13 commits into from
Aug 6, 2024

Conversation

yaswant
Copy link
Collaborator

@yaswant yaswant commented Feb 16, 2024

Update CI workflows

  • implement build-group strategy
  • update test CMakeLists to always include coding norms

Example build group annotation

build-group=JCSDA-internal/oops#2714

@yaswant yaswant self-assigned this Feb 16, 2024
@yaswant yaswant added the INFRA label Feb 16, 2024
@yaswant yaswant marked this pull request as ready for review February 16, 2024 11:22
@yaswant
Copy link
Collaborator Author

yaswant commented Feb 16, 2024

I anticipate the manual workflow to work okay with manual trigger, but cant be tested until merged in develop. I may need to open a follow-up PR in case the manual workflow proves problematic.

@yaswant yaswant requested a review from odlomax February 16, 2024 11:25
Copy link
Collaborator

@matthewrmshin matthewrmshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible.

@yaswant
Copy link
Collaborator Author

yaswant commented Aug 5, 2024

@phlndrwd @odlomax - can you review this PR please?

@yaswant
Copy link
Collaborator Author

yaswant commented Aug 6, 2024

@phlndrwd note that monio tests still depend on legacy lfric-lite test data. Worth moving them to monio's own test suite or use cases from lfric-jedi instead?

@phlndrwd
Copy link
Collaborator

phlndrwd commented Aug 6, 2024

@phlndrwd note that monio tests still depend on legacy lfric-lite test data. Worth moving them to monio's own test suite or use cases from lfric-jedi instead?

Thanks @yaswant. I guess this would be a trade-off between when the legacy data is due to disappear and when XIOS is expected to take-over from MONIO. If there is significant overlap then I don't think it would be worth making any significant changes here. Though I'm not in a position to answer this alone so it might be a conversation to be had with @odlomax, @matthewrmshin, & @mo-joshuacolclough, et al.

@yaswant yaswant merged commit dc4dbb4 into develop Aug 6, 2024
4 checks passed
@yaswant yaswant deleted the feature/ci_update branch August 6, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants