Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect netcdf-fortran. #42

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Detect netcdf-fortran. #42

merged 1 commit into from
Jul 19, 2024

Conversation

DJDavies2
Copy link
Contributor

I have added detection of netcdf-fortran in addition to netcdf-cxx. Resolves #41.

@phlndrwd
Copy link
Collaborator

Out of curiosity, @DJDavies2. Why does this change need to be made? MONIO does not use the Fortran NetCDF library. My feeling would be the issue is with the environment that is trying to build MONIO.

Copy link
Collaborator

@phlndrwd phlndrwd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a general comment above.

@DJDavies2 DJDavies2 merged commit 651ab51 into develop Jul 19, 2024
4 checks passed
@DJDavies2 DJDavies2 deleted the bugfix/41 branch July 19, 2024 11:24
@DJDavies2
Copy link
Contributor Author

There could be a problem with the environment, but it is very unclear what the environment is supposed to be for these things. If you have an idea for what should work I could try it and see what happens?

@phlndrwd
Copy link
Collaborator

phlndrwd commented Jul 24, 2024

There could be a problem with the environment, but it is very unclear what the environment is supposed to be for these things. If you have an idea for what should work I could try it and see what happens?

Thanks @DJDavies2. I've sent you a meeting invite.

@DJDavies2 DJDavies2 mentioned this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ecbuild failure to detect netcdf-fortran when building standalone.
3 participants