Refactored AtlasProcessor class to UtilsAtlas functions file #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tained a few simple functions.
mo-joshuacolclough
approved these changes
Aug 11, 2023
Comment on lines
+113
to
+133
| atlas::util::Config atlasOptions = atlas::option::name(field.name()) | | ||
| atlas::option::levels(field.levels()) | | ||
| atlas::option::global(0); | ||
|
|
||
| atlas::array::DataType atlasType = field.datatype(); | ||
| const auto& functionSpace = field.functionspace(); | ||
| atlas::Field globalField; | ||
| switch (atlasType.kind()) { | ||
| case atlasType.KIND_REAL64: | ||
| globalField = functionSpace.createField<double>(atlasOptions); | ||
| break; | ||
| case atlasType.KIND_REAL32: | ||
| globalField = functionSpace.createField<float>(atlasOptions); | ||
| break; | ||
| case atlasType.KIND_INT32: | ||
| globalField = functionSpace.createField<int>(atlasOptions); | ||
| break; | ||
| default: | ||
| utils::throwException("AtlasProcessor::getGlobalFieldSet())> " | ||
| "Data type not coded for..."); | ||
| } |
There was a problem hiding this comment.
As a side note - it is possible to do (perhaps you knew already in which case pls ignore):
atlas::Field f = fs.createField(atlas::option::name(field.name() |
atlas::option::levels(field.levels) |
atlas::option::global(0) |
atlas::option::datatype(field.datatype())); // added line(where fs is a functionspace)
Although I can see how it might be useful to catch the data types not coded for in the rest of the code.
There was a problem hiding this comment.
I didn't know that! Thanks for the tip.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the small size and simplicity of the AtlasProcessor class, it has been changed into a simple UtilsAtlas functions file.
Current test outputs: http://fcm1/cylc-review/taskjobs/punderwo/?suite=monio_refactor_atlasprocessor