Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/sla do not assimilate #56

Merged
merged 4 commits into from
Jul 13, 2023
Merged

Conversation

twsearle
Copy link
Collaborator

@twsearle twsearle commented Jul 10, 2023

Description

Added do-not-assimilate flags for the whole-profile and whole-report quality control entries.

This change also includes some minor refactoring, as the QCLevel integers were getting me quite confused. I have moved these to an enum class, for type safety.

Issues fixed

Testing

@twsearle twsearle requested a review from s-good July 10, 2023 22:15
@twsearle twsearle self-assigned this Jul 11, 2023
Copy link
Collaborator

@s-good s-good left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for sorting this.

@twsearle twsearle marked this pull request as ready for review July 13, 2023 09:21
@twsearle twsearle merged commit 7730763 into develop Jul 13, 2023
2 checks passed
@twsearle twsearle deleted the bugfix/sla-do-not-assimilate branch November 16, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Depth fill value
2 participants