Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update license to BSD 3-clause #61

Merged
merged 2 commits into from
Nov 21, 2023
Merged

update license to BSD 3-clause #61

merged 2 commits into from
Nov 21, 2023

Conversation

twsearle
Copy link
Collaborator

@twsearle twsearle commented Nov 16, 2023

Description

Update the license to BSD 3-clause to match that used by other public met office packages such as MetOffice/opsinputs/pull/167

Issue(s) addressed

Part of #60

Impact

None expected.

Checklist

  • functions are documented briefly via Doxygen comments in the code
  • I have run the unit tests
  • I have run mo-bundle to check integration with the rest of JEDI and run the unit tests under all environments

@twsearle twsearle changed the title update license update license to BSD clause 3 Nov 16, 2023
@twsearle twsearle changed the title update license to BSD clause 3 update license to BSD 3-clause Nov 16, 2023
Copy link
Collaborator

@matthewrmshin matthewrmshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

One minor point. We have now a mixture of Crown Copyright and British Crown Copyright. Worth making them consistent?

(Our branding team will argue for Crown Copyright instead of British Crown Copyright. For international collaboration, however, British Crown Copyright is likely to be more diplomatic. The choice is yours. 😄)

@twsearle
Copy link
Collaborator Author

@matthewrmshin Thanks! I hadn't noticed that it was all a bit of a mismatch. Hopefully I have caught all of those and converted them over now. I have removed any attempts at monarchy erasure for the Dutch, Spanish etc 😄

Copy link
Collaborator

@matthewrmshin matthewrmshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Testing in my environment to make sure it builds OK. Will approve when done.

Copy link
Collaborator

@matthewrmshin matthewrmshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in my environment. Works as expected.

@twsearle twsearle merged commit c976cd3 into develop Nov 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants