Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update where clause #67

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Update where clause #67

merged 1 commit into from
Jan 30, 2024

Conversation

twsearle
Copy link
Collaborator

@twsearle twsearle commented Jan 23, 2024

Description

Small syntactic change required by coordinated merge date of Friday 26th January.

This is in response to requirements of: ​JCSDA-internal/ufo/pull/3168

Issue(s) addressed

Resolves #65

Dependencies

List the other PRs that this PR is dependent on:

  • ​JCSDA-internal/ufo/pull/3168

Impact

None expected.

Checklist

  • I have run mo-bundle to check integration with the rest of JEDI and run the unit tests under all environments

@twsearle twsearle requested a review from s-good January 23, 2024 15:46
@twsearle twsearle self-assigned this Jan 23, 2024
@twsearle
Copy link
Collaborator Author

Note, the ctest failures are expected as we can't yet run CI against a particular ufo branch. I might add this in the future, but for now I will settle for rerunning on Friday after the UFO change is merged.

Copy link
Collaborator

@s-good s-good left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine to me.

@twsearle twsearle merged commit 97ed77c into develop Jan 30, 2024
2 checks passed
@twsearle twsearle deleted the feature/update-where-clause branch January 30, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt to changes to "process where" filter action arguments
2 participants