Unrotate 10m winds #190
Merged
Unrotate 10m winds #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctgh
approved these changes
Nov 27, 2023
smnewman
approved these changes
Nov 29, 2023
|
@james-cotton if this is ready please add the ready to merge flag and I'll merge |
|
Also is it worth running any of the kgo's or not? |
|
@mikecooke77 I have just run the ukv KGO with this build and the sonde output is unchanged I have also verified the Scatwind output is unrotated as expected. |
|
Are you ok to merge this? @mikecooke77 Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the UKV, we need to unrotate the wind components u10 and v10 before writing out the CX columns, as was done for u and v in #133 .
Fixes #140
n.b. Changes are easier to view if whitespace changes are hidden.