Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a smal change to bugfix map chans for seviri to work correctly. #192

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

orlewis
Copy link
Contributor

@orlewis orlewis commented Dec 19, 2023

When final testing was carried out on Seviri the VAR statistics did not look correct. This problem was only happening for channel 6.

The bug comes about from seviri having 6 channels read in but only 5 output to the varobs. This meant that a loop which cycled on the number of channels went round 6 times. A variable called arrayindex was used to assign where in an array to palce a value, this is initially set as the loop number. For seviri the logic follows a route where the arrayindex was updated to be the actual channel number, however on the final loop 6 the if logic prevents the arrayindex being reallocated and so channel 6 gets filled with the final channel 11 observations.

This is fixed by setting an exit on the loop if the condition is not met.

@orlewis orlewis self-assigned this Dec 19, 2023
Copy link
Collaborator

@ctgh ctgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks like a straightforward change.

Copy link
Contributor

@PJLevensMO PJLevensMO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this fix. I have tested this change for SEVIRI, and it fixes the problem with channel 6. I have also checked the effect on the other Geo instruments (ABI and AHI) and they remain the same, as expected.

@ctgh ctgh merged commit 11b8d18 into develop Dec 19, 2023
5 of 6 checks passed
@ctgh ctgh deleted the bugfix/seviri_mapchans branch December 19, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants