Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/improve error handling of specifying the grid #104

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

twsearle
Copy link
Collaborator

@twsearle twsearle commented Jul 25, 2024

Description

If a grid specification file is not found, orca-jedi will attempt to interpret the file path as a grid type. This leads to a confusing error when the name is not found.

This change checks for the validity of the grid option as a named ORCA grid first, if it is not found, then we assume the grid is a path to a specification file. If the file is not found then a more sensible error is raised.

Impact

No downstream impact.

Checklist

  • I have updated the unit tests to cover the change
  • New functions are documented briefly via Doxygen comments in the code
  • I have linted my code using cpplint
  • I have run the unit tests
  • I have run mo-bundle to check integration with the rest of JEDI and run the unit tests under all environments

@twsearle twsearle marked this pull request as ready for review July 25, 2024 13:02
@twsearle twsearle requested a review from s-good July 25, 2024 13:02
@twsearle twsearle self-assigned this Jul 25, 2024
Copy link
Collaborator

@s-good s-good left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks.

@twsearle twsearle merged commit 4c75730 into develop Jul 25, 2024
2 checks passed
@twsearle twsearle deleted the feature/improve-atlas-grid-selection-errors branch July 29, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants