sr3 sanity behaves badly with instances > 100.

[petersilva]

relates to #1183 but for sr3, so does not close the bug.
This is a patch for sr3 to deal with instance numbers > 100.
There is no digit limit after these patches are applied.
note: >40 is usually not useful... but special circumstances may apply.
Still instance numbers > 100 are likely often unhelpful.
Fixing anyways.

[petersilva]

with the patch, start, stop status work ok, but if you kill a pid, and then run sanity... it does weird stuff.

[petersilva]

sample without this patch:

SSC-5CD2310S60% sr3 status
status:
Component/Config     Processes   Connection        Lag                              Rates
                     State   Run Retry  msg data   Que   LagMax   LagAvg     Last  %rej     pubsub   messages     RxData     TxData
                     -----   --- -----  --- ----   ---   ------   ------     ----  ----     ------   --------     ------     ------
subscribe/hpfx_amis  part  120/120     0 100%   0%     0    0.00s    0.00s    0.08s 100.0%      73B/s       0m/s       0B/s       0B/s
watch/master         stop    0/0     0   0%   0%     0    0.00s    0.00s        0  0.0%       0B/s       0m/s       0B/s       0B/s
pid:831503 "/usr/bin/python3 /home/peter/sr3/sarracenia/instance.py --no 1 start subscribe/hpfx_amis" is not a configured instance
pid:831504 "/usr/bin/python3 /home/peter/sr3/sarracenia/instance.py --no 2 start subscribe/hpfx_amis" is not a configured instance
pid:831505 "/usr/bin/python3 /home/peter/sr3/sarracenia/instance.py --no 3 start subscribe/hpfx_amis" is not a configured instance
pid:831507 "/usr/bin/python3 /home/peter/sr3/sarracenia/instance.py --no 5 start subscribe/hpfx_amis" is not a configured instance
pid:831509 "/usr/bin/python3 /home/peter/sr3/sarracenia/instance.py --no 7 start subscribe/hpfx_amis" is not a configured instance
pid:831512 "/usr/bin/python3 /home/peter/sr3/sarracenia/instance.py --no 10 start subscribe/hpfx_amis" is not a configured instance
pid:831526 "/usr/bin/python3 /home/peter/sr3/sarracenia/instance.py --no 20 start subscribe/hpfx_amis" is not a configured instance
pid:831764 "/usr/bin/python3 /home/peter/sr3/sarracenia/instance.py --no 104 start subscribe/hpfx_amis" is not a configured instance
pid:831768 "/usr/bin/python3 /home/peter/sr3/sarracenia/instance.py --no 106 start subscribe/hpfx_amis" is not a configured instance
pid:831777 "/usr/bin/python3 /home/peter/sr3/sarracenia/instance.py --no 108 start subscribe/hpfx_amis" is not a configured instance
pid:831784 "/usr/bin/python3 /home/peter/sr3/sarracenia/instance.py --no 109 start subscribe/hpfx_amis" is not a configured instance
pid:831790 "/usr/bin/python3 /home/peter/sr3/sarracenia/instance.py --no 111 start subscribe/hpfx_amis" is not a configured instance
pid:831793 "/usr/bin/python3 /home/peter/sr3/sarracenia/instance.py --no 112 start subscribe/hpfx_amis" is not a configured instance
pid:831796 "/usr/bin/python3 /home/peter/sr3/sarracenia/instance.py --no 113 start subscribe/hpfx_amis" is not a configured instance
pid:831798 "/usr/bin/python3 /home/peter/sr3/sarracenia/instance.py --no 114 start subscribe/hpfx_amis" is not a configured instance
pid:831806 "/usr/bin/python3 /home/peter/sr3/sarracenia/instance.py --no 115 start subscribe/hpfx_amis" is not a configured instance
pid:831807 "/usr/bin/python3 /home/peter/sr3/sarracenia/instance.py --no 116 start subscribe/hpfx_amis" is not a configured instance
pid:831808 "/usr/bin/python3 /home/peter/sr3/sarracenia/instance.py --no 117 start subscribe/hpfx_amis" is not a configured instance
pid:831809 "/usr/bin/python3 /home/peter/sr3/sarracenia/instance.py --no 118 start subscribe/hpfx_amis" is not a configured instance
pid:831812 "/usr/bin/python3 /home/peter/sr3/sarracenia/instance.py --no 119 start subscribe/hpfx_amis" is not a configured instance
      Total Running Configs:   1 ( Processes: 120 missing: 0 stray: 20 )
                     Memory: uss:3.9GiB rss:5.2GiB vms:7.2GiB
                   CPU Time: User:151.27s System:22.69s
           Pub/Sub Received: 46m/s (6.3KiB/s), Sent:  0m/s (0B/s) Queued: 0 Retry: 0, Mean lag: 0.00s
              Data Received: 0f/s (0B/s), Sent: 0f/s (0B/s)
SSC-5CD2310S60%

I think it is getting confused between 1 and 101... causing lower number instances to be considered affected... this will infect/affect sanity as well.

[github-actions]

Test Results

248 tests   246 ✅  1m 30s ⏱️
  1 suites    1 💤
  1 files      1 ❌

For more details on these failures, see this check.

Results for commit 9d71239.

♻️ This comment has been updated with latest results.