Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CELE-107 Selection sync across widgets #64

Open
wants to merge 20 commits into
base: develop
Choose a base branch
from
Open

Conversation

dvcorreia
Copy link
Member

Acceptance criteria:

  • If I select a neuron, the selection should be reflected across widgets of the same workspace, for instance if I click in the graph ADA, the same neuron should light up/ be selected in the 3d viewer. For the EM viewer instead this neuron should be the only one visible for the segmentations, hide all the others.
  • The selection can be performed from any widget, graph, 3d viewer or EM viewer.

@dvcorreia dvcorreia self-assigned this Oct 14, 2024
@dvcorreia dvcorreia marked this pull request as ready for review October 31, 2024 19:19
Copy link
Member

@aranega aranega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good in a general way :), I only ask for few modifications on some parts of the code as it would help to gain in clarity.

@dvcorreia
Copy link
Member Author

Review changes done! Thanks @aranega 🙏

@aranega aranega self-requested a review November 4, 2024 12:18
Copy link
Member

@aranega aranega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good :) thanks @dvcorreia ! 🙏

@aranega aranega marked this pull request as draft November 4, 2024 17:33
@aranega
Copy link
Member

aranega commented Nov 4, 2024

I converted again the PR to draft because of a small bug that I forgot is not tackled (about selecting a neuron in the 2D graph viewer, then clearing the selection in EM, and not having the selection style removed from the 2D viewer).

I'm working on it.

@aranega aranega marked this pull request as ready for review November 5, 2024 15:08
@aranega aranega requested review from ddelpiano and removed request for afonsobspinto November 5, 2024 15:11
@aranega
Copy link
Member

aranega commented Nov 5, 2024

@dvcorreia @ddelpiano I finally found the way to have something logical when a class neuron is selected in the 2D graph, and the various interactions with the 3D/EM viewers. It wasn't easy to find a first solution that would fit some scenarios.

@aranega
Copy link
Member

aranega commented Nov 5, 2024

@dvcorreia @ddelpiano I finally was able to fix the last issue with the synchronizers. Now all should be just fine 🙏

Copy link
Member

@ddelpiano ddelpiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aranega @dvcorreia could one of you bring the latest development inside this branch please? There are changes that are obsolete now (e.g. the threeDsettings.ts changes are coming from the last PRs that Salam opened and she fixed a bunch of issues with those). Thanks!

@aranega
Copy link
Member

aranega commented Nov 6, 2024

@ddelpiano the branch is already up to date with develop, I modified the threeDsettings.ts file as there was warning in the console. Three is not considering string for colors but numbers. As the string wasn't recognize, it was interpreted by three/fiber as pure white (0xFFFFFF).

@dvcorreia
Copy link
Member Author

Also confirmed that is up to date with develop

@dvcorreia
Copy link
Member Author

@ddelpiano, I tested this and seems to work quite well. The issues we had with the neuron selected highlight in the 2D view seemed to have been solved, thanks @aranega :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants