-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CELE-107 Selection sync across widgets #64
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good in a general way :), I only ask for few modifications on some parts of the code as it would help to gain in clarity.
applications/visualizer/frontend/src/components/viewers/EM/EMStackTilesViewer.tsx
Outdated
Show resolved
Hide resolved
applications/visualizer/frontend/src/components/viewers/EM/EMStackTilesViewer.tsx
Outdated
Show resolved
Hide resolved
applications/visualizer/frontend/src/components/viewers/EM/EMStackTilesViewer.tsx
Outdated
Show resolved
Hide resolved
applications/visualizer/frontend/src/components/viewers/EM/EMStackTilesViewer.tsx
Outdated
Show resolved
Hide resolved
applications/visualizer/frontend/src/components/viewers/EM/EMStackTilesViewer.tsx
Outdated
Show resolved
Hide resolved
applications/visualizer/frontend/src/components/viewers/EM/neuronsMapFeature.ts
Outdated
Show resolved
Hide resolved
Review changes done! Thanks @aranega 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good :) thanks @dvcorreia ! 🙏
I converted again the PR to draft because of a small bug that I forgot is not tackled (about selecting a neuron in the 2D graph viewer, then clearing the selection in EM, and not having the selection style removed from the 2D viewer). I'm working on it. |
e78fd12
to
1afe2eb
Compare
@dvcorreia @ddelpiano I finally found the way to have something logical when a class neuron is selected in the 2D graph, and the various interactions with the 3D/EM viewers. It wasn't easy to find a first solution that would fit some scenarios. |
@dvcorreia @ddelpiano I finally was able to fix the last issue with the synchronizers. Now all should be just fine 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aranega @dvcorreia could one of you bring the latest development inside this branch please? There are changes that are obsolete now (e.g. the threeDsettings.ts changes are coming from the last PRs that Salam opened and she fixed a bunch of issues with those). Thanks!
@ddelpiano the branch is already up to date with develop, I modified the threeDsettings.ts file as there was warning in the console. Three is not considering string for colors but numbers. As the string wasn't recognize, it was interpreted by three/fiber as pure white (0xFFFFFF). |
Also confirmed that is up to date with develop |
@ddelpiano, I tested this and seems to work quite well. The issues we had with the neuron selected highlight in the 2D view seemed to have been solved, thanks @aranega :) |
Acceptance criteria: