-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CH-59 Update/Refactor the django application template #770
Conversation
class Migration(migrations.Migration): | ||
|
||
dependencies = [ | ||
("cloudharness_django", "0001_initial"), | ||
("ch_django", "0001_initial"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cloudharness_django is a dependency that comes from the base image, see https://github.com/MetaCell/cloud-harness/tree/develop/infrastructure/common-images/cloudharness-django/libraries/cloudharness-django. As the name ch_django from what I see is already creating confusion, I'm for using a different name, such as django_baseapp
3ffc9cf
to
ae198ee
Compare
…of implicit on import
…_event_service call idempotent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes CH-59
Made the changes detailed in the ticket, and associated changes required to get it to function.
...
Create a new sample django app, the structure should be in the updated format and when deploying the correct migrations are run.
...
Sanity checks:
Breaking changes (select one):
breaking-change
and the migration procedure is well described abovePossible deployment updates issues (select one):
alert:deployment
Test coverage (select one):
Documentation (select one):
Nice to have (if relevant):