Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CH-59 Update/Refactor the django application template #770

Merged
merged 22 commits into from
Sep 27, 2024
Merged

Conversation

condar-metacell
Copy link
Contributor

@condar-metacell condar-metacell commented Sep 13, 2024

Closes CH-59

Made the changes detailed in the ticket, and associated changes required to get it to function.

...

Create a new sample django app, the structure should be in the updated format and when deploying the correct migrations are run.

...

Sanity checks:

  • The pull request is explicitly linked to the relevant issue(s)
  • The issue is well described: clearly states the problem and the general proposed solution(s)
  • In this PR it is explicitly stated how to test the current change
  • The labels in the issue set the scope and the type of issue (bug, feature, etc.)
  • The relevant components are indicated in the issue (if any)
  • All the automated test checks are passing
  • All the linked issues are included in one Sprint
  • All the linked issues are in the Review state
  • All the linked issues are assigned

Breaking changes (select one):

  • The present changes do not change the preexisting api in any way
  • This PR and the issue are tagged as a breaking-change and the migration procedure is well described above

Possible deployment updates issues (select one):

  • There is no reason why deployments based on CloudHarness may break after the current update
  • This PR and the issue are tagged as alert:deployment

Test coverage (select one):

  • Tests for the relevant cases are included in this pr
  • The changes included in this pr are out of the current test coverage scope

Documentation (select one):

  • The documentation has been updated to match the current changes
  • The changes included in this PR are out of the current documentation scope

Nice to have (if relevant):

  • Screenshots of the changes
  • Explanatory video/animated gif

@condar-metacell condar-metacell added the enhancement New feature or request label Sep 13, 2024
class Migration(migrations.Migration):

dependencies = [
("cloudharness_django", "0001_initial"),
("ch_django", "0001_initial"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cloudharness_django is a dependency that comes from the base image, see https://github.com/MetaCell/cloud-harness/tree/develop/infrastructure/common-images/cloudharness-django/libraries/cloudharness-django. As the name ch_django from what I see is already creating confusion, I'm for using a different name, such as django_baseapp

Copy link
Collaborator

@filippomc filippomc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@filippomc filippomc merged commit 5943858 into develop Sep 27, 2024
7 of 8 checks passed
@filippomc filippomc deleted the feature/ch-59 branch September 27, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants