Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Toolbar should use only standard material ui theme attributes #442

Open
afonsobspinto opened this issue Dec 12, 2022 · 1 comment · Fixed by #463
Open

Custom Toolbar should use only standard material ui theme attributes #442

afonsobspinto opened this issue Dec 12, 2022 · 1 comment · Fixed by #463
Assignees
@afonsobspinto
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@afonsobspinto
Copy link
Member

afonsobspinto commented Dec 12, 2022 •
edited
Loading

Having very specific theme references makes the component hard to reuse.

Please consider replacing:
https://github.com/MetaCell/geppetto-meta/blob/master/geppetto.js/geppetto-ui/src/common/CustomToolbar.js#L14-L16

with component props
@afonsobspinto afonsobspinto added the enhancement New feature or request label Dec 12, 2022
@afonsobspinto afonsobspinto self-assigned this Dec 12, 2022
@afonsobspinto afonsobspinto added the good first issue Good for newcomers label Dec 12, 2022
afonsobspinto added a commit that referenced this issue Dec 12, 2022
@afonsobspinto
#442 feat: Remove unusual material UI theme references
946edc9
@afonsobspinto afonsobspinto mentioned this issue Dec 12, 2022
Closed
@afonsobspinto afonsobspinto linked a pull request Dec 12, 2022 that will close this issue
Features/442 to 446 #449
Closed
@afonsobspinto afonsobspinto added this to the 2.0.0 milestone Dec 16, 2022
afonsobspinto added a commit that referenced this issue Dec 20, 2022
@afonsobspinto
#442 feat: Update customToolbar styling strategy
57e34ed
@afonsobspinto afonsobspinto removed a link to a pull request Dec 20, 2022
Features/442 to 446 #449
Closed
@afonsobspinto afonsobspinto removed this from the Major milestone Dec 20, 2022
@afonsobspinto afonsobspinto changed the title Custom Toolbar should use only standard material ui theme atriubutes Custom Toolbar should use only standard material ui theme attributes Dec 27, 2022
afonsobspinto added a commit that referenced this issue Dec 27, 2022
@afonsobspinto
#442 feat: Remove non-standard theme attributes
70d060d
afonsobspinto added a commit that referenced this issue Dec 28, 2022
@afonsobspinto
#442 feat: Update examples and fix typo
6d50266
@afonsobspinto afonsobspinto mentioned this issue Dec 28, 2022
Merged
@afonsobspinto
Copy link
Member Author

Duplicate of #98

@afonsobspinto afonsobspinto marked this as a duplicate of #98 Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afonsobspinto afonsobspinto

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Features/442 448 MetaCell/geppetto-meta
1 participant
@afonsobspinto